-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consensus appeal success should rollback all newer transactions to pending #768
Open
kstroobants
wants to merge
46
commits into
main
Choose a base branch
from
662-consensus-appeal-success-should-rollback-all-newer-transactions-to-pending
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: consensus appeal success should rollback all newer transactions to pending #768
kstroobants
wants to merge
46
commits into
main
from
662-consensus-appeal-success-should-rollback-all-newer-transactions-to-pending
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inalized rollup transaction
…op when appeal failed and succeeded
…ed state and add button also to modal
- Add N+2 validators, remove leader - Use latest data of transaction when in pending state and not the old one from the crawler - Write consensus data before setting status to have it updated in frontend when going to transaction info modal - Do not deploy contract when transaction was in the undetermined state
…eals-implement-sequential-appeals-fail
…8-appeals-undetermined-transactions
…sation of transaction
…undetermined-transactions
…nly check in appeal_window
…king on finalized state gave a small delay in showing when appeal failed and finality window was exceeded
… transactions to pending
…sus-appeal-success-should-rollback-all-newer-transactions-to-pending
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
- Coverage 18.21% 18.16% -0.06%
==========================================
Files 129 129
Lines 10076 10104 +28
Branches 302 302
==========================================
Hits 1835 1835
- Misses 8156 8184 +28
Partials 85 85 ☔ View full report in Codecov by Sentry. |
…-all-newer-transactions-to-pending
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #662
What
Why
Testing done
Decisions made
Checks
Reviewing tips
Check code changes and try it.
User facing release notes
A leader appeal success and validator appeal success will rollback all newer transactions to the pending status.